Re: [Preliminary Review]: Proposal for back-porting JFR to OpenJDK8u

[guangyu.zhu]

To verify the "disabled" parameter, I just tried "./configure --disable-jfr" and then "make" jvm in a docker on x86-64 linux. Using the image, I can't start java with "-XX:StartFlightRecording = xxx", and also can't start JFR with jcmd. Hope this can help.

Thanks,
Guangyu
------------------------------------------------------------------
Sender:Mario Torre <neugens at redhat.com>
Sent At:2019 Feb. 28 (Thu.) 21:34
Recipient:Andrey Petushkov <andrey at azul.com>
Cc:guangyu.zhu <guangyu.zhu at aliyun.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject:Re: [Preliminary Review]: Proposal for back-porting JFR to OpenJDK8u

On Thu, 2019-02-28 at 10:10 +0000, Andrey Petushkov wrote:
> Sorry, no matter how hard I try I cannot repeat this problem :(
> If I configure with --disable-jfr there are no JFR-related VM flags,
> diagnostic commands or beans (checked with command line and JMC). 
> So I see no means to initiate JFR dump.
> Could you please elaborate what target platform you're building for
> (I've checked on x86_64) and your exact configure parameters

This is interesting.

So, my system is a Fedora 28, x86_64, at this moment, I'm using this
configure:

$ sh configure --with-extra-cflags=-Wno-error --disable-jfr

The configure picks up the option correct as far as I can see
(config.log):

ENABLE_JFR='false'

If you can't replicate it, it's likely something wrong I'm doing, so
let's step back a second and see what's the full process.

I take the patches from here:
http://cr.openjdk.java.net/~apetushkov/jfr8/

And apply them in order:

jdk8u-jfr-incubator/zulu8-emb-dev.patch
jdk8u-jfr-incubator/jdk/jdk.patch
jdk8u-jfr-incubator/hotpost/hotspot.patch

I didn't apply the others as at this moment I'm not building any of
those targets, the patches don't contain any build related changes
anyway.

After that, I invoke my configure script, at this point no matter if I
pass  --disable-jfr or --enable-jfr I still end up with a full JFR
build.

What steps am I missing?

Cheers,
Mario

-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898