RFR: JDK8U Backport of 8217609: New era placeholder not recognized by java.text.SimpleDateFormat

[Deepak Kejriwal]

Hi Andrew,

Thanks for review. As of now we don't which bug need to be backported to 8u for fixing CLDR convertor issue. However, I have raised a separate bug for same:-
https://bugs.openjdk.java.net/browse/JDK-8220020

Regards,
Deepak 

-----Original Message-----
From: Andrew Hughes <gnu.andrew at redhat.com> 
Sent: Friday, March 1, 2019 9:09 PM
To: Deepak Kejriwal <deepak.kejriwal at oracle.com>
Cc: core-libs-dev <core-libs-dev at openjdk.java.net>; jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject: Re: RFR: JDK8U Backport of 8217609: New era placeholder not recognized by java.text.SimpleDateFormat

On Fri, 1 Mar 2019 at 10:47, Deepak Kejriwal <deepak.kejriwal at oracle.com> wrote:
>
> Hi All,
>
>
>
> Please review the back port of fix for JDK-8217609 to 8u-dev:-
>
>
>
> JBS report: HYPERLINK 
> "https://bugs.openjdk.java.net/browse/JDK-%208217609%22https://bugs.op
> enjdk.java.net/browse/JDK- 8217609
>
> Webrev: 
> http://cr.openjdk.java.net/~pkoppula/dkejriwal/8217609/webrev.00/
>
> Master bug change set:  
> http://hg.openjdk.java.net/jdk/jdk/rev/8ea340a71f17
>
> Summary:
> Fix is backported from JDK 13 to JDK 8u and is not a clean backport. 
> Reason for that is because JDK uses CLDR version 21.01 and JDK 13 uses 
> version 33. Below are the differences between 8u and 13:-
>
> .         The "jp.xml" version of JDK 8u does not contains "<eraNarrow>" node (<calendar type=japanese">). Therefore "<era type="236">N</era>" which is part of fix is not added to file.
>
> .         I've commented out one of the test data { LONG, JAPAN, "\u5143\u53f7" } in "JapaneseEraNameTest.java"  for JDK 8u.  It checks era name returned by method "java.util.Calendar.getDisplayName(int field, int style, Locale locale)"
>
> o   The  test fails for this particular data on prior 8u releases across all existing eras(HEISI,SHOWA,..).
>
> o   The cause of issue is that CLDR java resource file (FormatData_ja.java) generated by "CLDR Converter" does not contain required resource key "japanese.long.Eras".  The "CLDR Converter" need to be fixed to address this issue. Since this issue is an existing issue data point { LONG, JAPAN, "\u5143\u53f7" } is removed from "JapaneseEraNameTest.java" for 8u.
>
> Regards,
>
> Deepak
>
>

Patch looks good to me.

Is there a bug/patch to backport to fix the CLDR converter in OpenJDK 8, so japanese.long.Eras are included?

JDK-8217609 should have the label 'jdk8u-fix-request' added so it can be approved for 8u.

Thanks,
--
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (https://urldefense.proofpoint.com/v2/url?u=http-3A__www.redhat.com&d=DwIFaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=OIRLm_rdyVUfNJH3SLA-tRzXEZ3NIKC14aO9CokPvgI&m=j3CCAe0gKdZ1tUX3wqQmQH0-QEcf9c-SP_A6NIFBobU&s=taCA3iR6U95qSdORcSSBkhnzDPXZDhrUKtyZjecFOGw&e=)

Web Site: https://urldefense.proofpoint.com/v2/url?u=http-3A__fuseyism.com&d=DwIFaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=OIRLm_rdyVUfNJH3SLA-tRzXEZ3NIKC14aO9CokPvgI&m=j3CCAe0gKdZ1tUX3wqQmQH0-QEcf9c-SP_A6NIFBobU&s=qf3t66gFRZcTpETTq7B7ur6kxz7LEX2z65dog1MIlKg&e=
Twitter: https://urldefense.proofpoint.com/v2/url?u=https-3A__twitter.com_gnu-5Fandrew-5Fjava&d=DwIFaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=OIRLm_rdyVUfNJH3SLA-tRzXEZ3NIKC14aO9CokPvgI&m=j3CCAe0gKdZ1tUX3wqQmQH0-QEcf9c-SP_A6NIFBobU&s=Kjo5wWD8vSXUKQhnMlZ9dNyEQWdR1QuHvqPAwz5hJ7c&e=
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222