[8u] RFR 8170681: Remove fontconfig header files from JDK source tree

[Dmitry Cherepanov]

Thanks for the review.
THIRD_PARTY_README has been updated for all repos.
Here’s the links to webrevs:

http://cr.openjdk.java.net/~dcherepanov/8170681/v0/webrev.root/
http://cr.openjdk.java.net/~dcherepanov/8170681/v0/webrev.jdk/
http://cr.openjdk.java.net/~dcherepanov/8170681/v0/webrev.hotspot/
http://cr.openjdk.java.net/~dcherepanov/8170681/v0/webrev.corba/
http://cr.openjdk.java.net/~dcherepanov/8170681/v0/webrev.jaxp/
http://cr.openjdk.java.net/~dcherepanov/8170681/v0/webrev.jaxws/
http://cr.openjdk.java.net/~dcherepanov/8170681/v0/webrev.langtools/
http://cr.openjdk.java.net/~dcherepanov/8170681/v0/webrev.nashorn/

Thanks,

Dmitry

On Mar 4, 2019, at 8:36 PM, Andrew John Hughes <gnu.andrew at redhat.com<mailto:gnu.andrew at redhat.com>> wrote:

On 01/03/2019 14:56, Dmitry Cherepanov wrote:
Please review/approve the backport of 8170681 to 8u-dev

JBS: https://bugs.openjdk.java.net/browse/JDK-8170681
Webrev (root repo): http://cr.openjdk.java.net/~dcherepanov/8170681/v0/webrev.root/
Webrev (jdk repo): http://cr.openjdk.java.net/~dcherepanov/8170681/v0/webrev.jdk/

The original patch doesn't apply cleanly to 8u-dev so it includes the following modifications
- In 9, the fix for JDK-8138761 includes refactoring that splits libraries.m4 into several files (file per tool). For 8u-dev, the backport patch updates the existing libraries.m4 for consistency.
- The original patch removes fontconfig.md with fontconfig license entry. For 8u-dev, the backport patch updates THIRD_PARTY_README files (for all repos).

Testing - repo with the patch builds on Windows/Mac. Also tested it on CentOS with and without fontconfig-devel installed.

Thanks,

Dmitry


Looks good to me.

Are there changes for the other repos too, for THIRD_PARTY_README?
I see it is present across them all (as was the case for recent libpng
updates):

$ for repos in . corba jaxp jaxws langtools nashorn jdk hotspot; do echo
${repos}; grep -ri 'fontconfig'
../../jdk8u-dev/${repos}/THIRD_PARTY_README; done
.
%% This notice is provided with respect to FontConfig 2.5, which may be
corba
%% This notice is provided with respect to FontConfig 2.5, which may be
jaxp
%% This notice is provided with respect to FontConfig 2.5, which may be
jaxws
%% This notice is provided with respect to FontConfig 2.5, which may be
langtools
%% This notice is provided with respect to FontConfig 2.5, which may be
nashorn
%% This notice is provided with respect to FontConfig 2.5, which may be
jdk
%% This notice is provided with respect to FontConfig 2.5, which may be
hotspot
%% This notice is provided with respect to FontConfig 2.5, which may be

Thanks,
--
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew