[RFR] 8220397: JDK-8036003 backport regresses no_strip builds

[Severin Gehwolf]

On Mon, 2019-03-11 at 07:33 +0000, Andrew John Hughes wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8220397
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8220397/webrev.01/
> 
> When JDK-8036003 was backported, it added a bunch of conditionals in
> make/common/NativeCompilation.gmk which cause debuginfo to not be
> generated if no_strip is set. However, the cases for ZIP_DEBUGINFO_FILES
> were missed, causing the build to fail, because there's no dependency
> for the .diz target.
> 
> I suspect this doesn't show up when the new configure option is
> specified, because ZIP_DEBUGINFO_FILES is toggled appropriately, but it
> does regress my existing builds which don't specify that option.

Sorry, but I'm not sure why this would be needed? There is a new
configure flag supporting these use-cases (including yours?):

no debug symbols: --with-native-debug-symbols=none (or old mechanims)
zipped debug symbols: --with-native-debug-symbols=zipped (or old mechanism)
no stripping at all: --with-native-debug-symbols=internal (no supported way previously)
external debug symbols: --with-native-debug-symbols=external (or old mechanism)

Why would you want to continue some unsupported way to produce the
equivalent of --with-native-debug-symbols=internal?

> Simple fix and 8u only.

Fix is simple enough, but it also encourages people to *not* change
their build scripts to the supported configure option :-(

Thanks,
Severin