[8u] [RFR] 8175120: Remove old tests on kdc timeout policy

[Andrew John Hughes]

On 13/03/2019 16:28, Aleksey Shipilev wrote:
> On 3/12/19 11:54 AM, Severin Gehwolf wrote:
>> On Mon, 2019-03-11 at 07:50 +0000, Andrew John Hughes wrote:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8175120
>>> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8175120/webrev.01/
> 
> This looks good, except the change in KdcPolicy.java. See below:
>>> Original review:
>>> https://mail.openjdk.java.net/pipermail/security-dev/2017-February/015625.html
>>>
>>> This is not a clean backport because the tests in 8u differ slightly
>>> from those in OpenJDK 10:
>>>
>>> 1. 8u has "JDK-8190690: Impact on krb5 test cases in the 8u nightly".
>>> That same change (adding a property to the @run line) also needs to be
>>> applied to the new KdcPolicy.java test for it to succeed.
> 
> It looks to me that change to KdcPolicy.java does not relate to 8175120 (this one). It would be
> confusing to backport that change under this bug ID? Maybe have a quick and separate 8u-specific fix?
> 

I guess. I didn't know about 8190690 until it came up as a diff between
the versions of the test in the backported patch and those in 8u. As
KdcPolicy.java was failing without it, it seemed logical to move it from
the files being removed to this new test so the replacement test was no
longer broken. But it does affect the clarity of the backport, you're right.

I've filed

https://bugs.openjdk.java.net/browse/JDK-8220641

for that issue and generated a new webrev for 8175120:

https://cr.openjdk.java.net/~andrew/openjdk8/8175120/webrev.02/


> Thanks,
> -Aleksey
> 

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew