[8u] RFR 8170681: Remove fontconfig header files from JDK source tree

[Liu, Xin]

Hi,  Andrew, 

Thanks for looking this issue.
I've put the label ' jdk8u-fix-request' on JDK-8192854
It's not necessary to go jdk8u-critical-request. 8u222 is fine. 

Thanks,
--lx

On 3/19/19, 6:19 PM, "jdk8u-dev on behalf of Andrew John Hughes" <jdk8u-dev-bounces at openjdk.java.net on behalf of gnu.andrew at redhat.com> wrote:

    On 20/03/2019 00:55, Liu, Xin wrote:
    > Hi, Dmitry,
    > For your backport,  I think jdk8u also need to backport this one.
    > https://bugs.openjdk.java.net/browse/JDK-8192854
    > 
    > If users specify –with-fontconfig, buildscript is supposed to use ‘FONTCONFIG_CFLAGS’ to discover the header file fontconfig/fontconfig.h.  If you ignore FONTCONFIG_CFLAGS,  it will fall back to pick up from /usr/include. It’s fine by almost Linux distros.  We(Amazon) put 3rd libraries in non-standard location.  That why we have this problem.
    > 
    > webrev for backport JDK-8192854
    > https://cr.openjdk.java.net/~xliu/8192854/webrev/
    > 
    > thanks,
    > --lx
    > 
    > 
    > 
    
    This looks fine to me. You should flag the bug with jdk8u-fix-request to
    get it into 8u222.
    
    If you want it in 8u212, which has branched, use jdk8u-critical-request
    instead.
    -- 
    Andrew :)
    
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
    https://keybase.io/gnu_andrew