RFR: JDK8U Backport of JDK-8042131 and JDK-8210633

[Deepak Kejriwal]

Hi Ramanand / Christoph,

Thanks for review. I think Naoto and Ramanand are right, we do update the copyright year when it is not a clean backport. Please find the updated version of webrev.

http://cr.openjdk.java.net/~rpatil/8042131_8210633/webrev.01/

Regards,
Deepak

-----Original Message-----
From: Ramanand Patil 
Sent: Monday, March 25, 2019 3:54 PM
To: Langer, Christoph <christoph.langer at sap.com>; Deepak Kejriwal <deepak.kejriwal at oracle.com>
Cc: Naoto Sato <naoto.sato at oracle.com>; core-libs-dev <core-libs-dev at openjdk.java.net>; jdk8u-dev at openjdk.java.net
Subject: RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633

Hi Christoph,
I have suggested the changes considering the fact that this is not a clean backport. Both the source and test files are manually edited and review is requested for the same.

Thank you for reminding about jdk8u-fix-request label, I think Deepak will add it.

Regards,
Ramanand.

> -----Original Message-----
> From: Langer, Christoph <christoph.langer at sap.com>
> Sent: Monday, March 25, 2019 12:42 PM
> To: Deepak Kejriwal <deepak.kejriwal at oracle.com>
> Cc: Ramanand Patil <ramanand.patil at oracle.com>; Naoto Sato 
> <naoto.sato at oracle.com>; core-libs-dev 
> <core-libs-dev at openjdk.java.net>; jdk8u-dev at openjdk.java.net
> Subject: RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633
> 
> Hi there,
> 
> since this is a downport for jdk/jdk, I think the copyright headers 
> should be the same as upstream.
> 
> So, for 
> src/share/classes/java/time/format/DateTimeFormatterBuilder.java,
> you should take 2018 as copyright year. For the test the headers look correct.
> 
> As for jdk8u push: Will you push it to OpenJDK 8 updates or to Oracle 
> 8 updates. For the former, you'll have to request downport by setting 
> the jdk8u-fix-request label in the bugs.
> 
> Best regards
> Christoph
> 
> > -----Original Message-----
> > From: jdk8u-dev <jdk8u-dev-bounces at openjdk.java.net> On Behalf Of 
> > Ramanand Patil
> > Sent: Montag, 25. März 2019 07:38
> > To: Deepak Kejriwal <deepak.kejriwal at oracle.com>; Naoto Sato 
> > <naoto.sato at oracle.com>; core-libs-dev 
> > <core-libs-dev at openjdk.java.net>; jdk8u-dev at openjdk.java.net
> > Subject: RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633
> >
> > Hi Deepak,
> >
> > In particular, the test TestDateTimeFormatterBuilderWithLocale.java
> > should have only one copyright year i.e. 2019, since this is a new 
> > file in jdk8u-dev repos. Also I think, you can omit the second 
> > copyright info(from line no. 24) for the same reason.
> >
> >
> > Note: I am not a reviewer for JDK 8 Updates Project.
> >
> > Regards,
> > Ramanand.
> >
> > > -----Original Message-----
> > > From: Deepak Kejriwal
> > > Sent: Monday, March 25, 2019 10:11 AM
> > > To: Naoto Sato <naoto.sato at oracle.com>; core-libs-dev <core-libs- 
> > > dev at openjdk.java.net>; jdk8u-dev at openjdk.java.net
> > > Subject: RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633
> > >
> > > Hi Naoto,
> > >
> > > Thanks for review. I will update the copyright information and 
> > > push the changes.
> > >
> > > Regards,
> > > Deepak
> > >
> > >
> > > -----Original Message-----
> > > From: Naoto Sato
> > > Sent: Friday, March 22, 2019 10:59 PM
> > > To: Deepak Kejriwal <deepak.kejriwal at oracle.com>; core-libs-dev
> > > <core- libs-dev at openjdk.java.net>; jdk8u-dev at openjdk.java.net
> > > Subject: Re: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633
> > >
> > > Hi Deepak,
> > >
> > > Please modify the copyright year accordingly. Otherwise it looks 
> > > good to
> > me.
> > >
> > > Naoto
> > >
> > > On 3/22/19 8:51 AM, Deepak Kejriwal wrote:
> > > > Hi All,
> > > >
> > > >
> > > >
> > > > Please review the back port of fix for JDK-8042131 and 
> > > > JDK-8210633 to 8u-
> > > dev:-
> > > >
> > > >
> > > >
> > > > JBS report: https://bugs.openjdk.java.net/browse/JDK-8042131
> > > >
> > > >        https://bugs.openjdk.java.net/browse/JDK-8210633
> > > >
> > > >
> > > >
> > > > Webrev:
> > http://cr.openjdk.java.net/~rpatil/8042131_8210633/webrev.00/
> > > >
> > > >
> > > >
> > > > Master bug change set:
> > > http://hg.openjdk.java.net/jdk/jdk/rev/f2d94a0619a2
> > > >
> > > > http://hg.openjdk.java.net/jdk/jdk/rev/a0426bc28519
> > > >
> > > > Summary:
> > > > The backport of fix for both bugs JDK-8042131 (from 11u) and 
> > > > JDK-
> > 8210633
> > > (from 12u) are not clean backport. Changes for file 
> > > "DateTimeFormatterBuilder.java" are manually merged. Since, test 
> > > file "TestDateTimeFormatterBuilderWithLocale.java" is new in 8u 
> > > release only test cases modified as part for JDK-8042131 and 
> > > JDK-8210633
> are added.
> > > >
> > > > All tests are run against the changes and found to be passing.
> > > >
> > > > Regards,
> > > >
> > > > Deepak
> > > >
> > > >
> > > >