[RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag
Langer, Christoph
christoph.langer at sap.com
Thu Mar 28 09:30:39 UTC 2019
Hi,
> > Revised HotSpot webrev:
> >
> > https://cr.openjdk.java.net/~andrew/openjdk8/8189761/hotspot.02
>
> +++ new/src/share/vm/runtime/vm_version.cpp 2019-03-28
> 03:52:51.384737947 +0000
> @@ -140,7 +140,7 @@
>
> const char* Abstract_VM_Version::vm_vendor() {
> #ifdef VENDOR
> - return XSTR(VENDOR);
> + return VENDOR;
>
> This looks like the change from JDK-8200115. Have you considered
> backporting this separately? Failing that, we should mention JDK-
> 8200115 in the backport commit message as well.
I suggest inlining the backport of 8200115 to this commit by adding "8200115: System property java.vm.vendor value includes quotation marks" to the commit message. It will resolve/backport 8200115 as well. Process wise we should probably tag 8200115 with jdk8u-critcal-request and get it approved, though?
Please also update the copyright years accordingly when pushing.
Thanks & Best regards
Christoph
More information about the jdk8u-dev
mailing list