RFR: 8223147: JFR Backport (to jdk8u)
Andrew John Hughes
gnu.andrew at redhat.com
Fri May 10 17:55:52 UTC 2019
snip...
>
>> One process question (thus Andrew in To), the new webrev currently only includes the code which applies to jdk8u-jfr-incubator
>> repo, but what about aarch64 and aarch32 ports which are not available there? I don't see a reason to prevent them from
>> having JFR and there is code ready for that ([1]). How could we proceed with integration of it?
>
> You are right, it didn't occur to me that this code was not part of
> the repository, but this is because the staging repo is forked from
> jdk8u-dev which doesn't contain those ports.
>
> I think we should indeed backport the other changes, perhaps once
> everything is in mainline we can push into the shenandoah/arm/etc...
> repositories individual patches?
>
> Cheers,
> Mario
>
Once JFR is integrated into the jdk8u repository, it will get merged
into the aarch64/shenandoah-jdk8u [0] and aarch32 [1] trees.
I don't see any problem in adding AArch{32,64} code blocks in the shared
code during the incubation period, but any changes to arch-specific
files will be against files that simply don't exist in the jdk8u trees.
When that occurs, it's worth taking a note of what changes have to be
left out so they can be added to the respective ports once JFR is
integrated.
[0] https://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/
[1] https://hg.openjdk.java.net/aarch32-port/jdk8u/
Thanks,
--
Andrew :)
Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew
More information about the jdk8u-dev
mailing list