RFR: [8218152] javac fails and exits with no error if a bad annotation processor is on the classpath

[Andrew John Hughes]

On 08/05/2019 13:26, Steve Groeger wrote:
> Hi Andrew,
> 
> Thanks for taking a look at this.
> 
>> Regarding the 8u webrev, the two additions for hasNext() and next() in
>> JavacProcessingEnvironment.java seem to have been flipped. Was this
>> intentional? Comparing patched jdk8u with the jdk/jdk version:
> 
> Yes, this was intentional. When I investigated this issue I did initially
> add the changes to hasNext() in the jdk8u code but that didn't resolve the
> issue. Having then looked at a generated stack trace it showed that the
> code was going thru the next() method and failing there rather than in
> hasNext(). Hence the reason the changes were put in the next() method for
> jdk8u and in the hasNext() for jdk11 and above. Seems the
> JavacProcessingEnvoronment.java class has changed since jdk8.
> 

Ah ok.


>> The test changes look ok and I assume they pass. 
> 
> Yes, the tests do pass when run on my local environment for all releases
> jdk8u, jdk11u and jdk12u.
> 
>> Long term, we may want to look at backporting
>> https://bugs.openjdk.java.net/browse/JDK-8050429
>> to avoid this work for every test.
> 
> I agree that we need to back-port this at some point. It gets quite time
> consuming having to change tests that are created on jdk11u+ and need to
> be back-ported to jdk8u.
> 
> Is there anything else I need to do in order to get these back-ports
> merged. If so, please let me know.
> 

I see you added jdk8u-fix-request, and it has a jdk8u-fix-yes in
response, so now it has been reviewed, all that's needed now is to push
the change.

Do you have push access or shall I do it on your behalf?

> Thanks
> Steve Groeger
> IBM Runtime Technologies
> Hursley, Winchester
> Tel: (44) 1962 816911  Mobex: 279990  Mobile: 07718 517 129
> Fax (44) 1962 816800
> Lotus Notes: Steve Groeger/UK/IBM
> Internet: groeges at uk.ibm.com
> 
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
> 

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew