[8u-dev] RFA (S): JDK-8210985: Update the default SSL session cache size to 20480

[Hohensee, Paul]

CSRs are definitely an Oracle thing. See https://wiki.openjdk.java.net/display/csr/Main.

At Oracle, if you want to change an interface or behavior, you file a JBS issue to do the work, then file a CSR to get approval for the interface change. Closing a CSR == approving it. Finalized state means it's ready for review. One is supposed to get consensus before finalizing a CSR.

If a backport involved a CSR, Oracle used to want a backport CSR, so the process was and maybe is: create a backport JBS issue, then a CSR for the backport issue, get the CSR approved, then get the backport approved. I don't know what Oracle's CSR backport process is now, but somehow I was under the impression that I should follow it. :) We could use Oracle's process for 8u and 11u, though it's a bit heavy-weight. It does have the advantage of thoroughly documenting interface/behavior changes in backports. I'm not sure who would do the backport CSR approvals: probably the Maintainers.

I was incorrect/hasty about 8u clean patch application. 8u doesn't have SSLLogger, so that code gets dropped from SSLSessionContextImpl.getDefaultCacheLimit().

8u webrev: http://cr.openjdk.java.net/~phh/8210985/webrev.8u.00/

The included test passes.

Thanks,

Paul

On 5/24/19, 2:22 PM, "Andrew John Hughes" <gnu.andrew at redhat.com> wrote:

    
    
    On 24/05/2019 21:26, Hohensee, Paul wrote:
    > Added. I was waiting on CSR approval, but Joe Darcy noted that we're not using CSRs for 8u, which I hadn't known (or had forgot!).
    > 
    > Thanks,
    > 
    > Paul
    > 
    
    I didn't know either, and was actually wondering what I was meant to
    approve here. As far as I could gather from the CSR page, it had already
    been approved by being in the "Finalized" state.
    
    Are CSRs an Oracle thing? I'm not sure how they even fit in with the
    non-Oracle run projects.
    
    Thanks,
    -- 
    Andrew :)
    
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
    https://keybase.io/gnu_andrew