[8u] RFR 8153732: Windows remote printer changes do not reflect in lookupPrintServices()

[Andrew John Hughes]

On 27/05/2019 16:56, Zhengyu Gu wrote:
> Hi,
> 
> Please review this backport to 8u.
> 
> The original patch can not apply to 8u without first renaming
> Win32PrintServiceLookup.java to PrintServiceLookupProvider.java, and
> fixing class names, references and native jni method signature. After
> that, the patch is clean.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8153732
> 
> Original changeset: http://hg.openjdk.java.net/jdk/client/rev/732a3b600098
> 
> 8u Backport Webrev:
> http://cr.openjdk.java.net/~zgu/JDK-8153732_8u/webrev.00/
> 
> Test:
>   manual testing: RemotePrinterStatusRefresh
> 
> Thanks,
> 
> -Zhengyu
> 

If you're going to perform the renaming, then JDK-8055705 should be
backported separately as a pre-requisite.  Bundling just the Windows
half of this into this changeset is going to cause confusion further
down the line.

Alternatively, the changes in 8153732 could just be applied directly to
WPrinterJob.cpp and Win32PrintServiceLookup.java in 8u, AFAICS.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew