[8u] RFR 8055705: Rename UnixPrintServiceLookup and Win32PrintServiceLookup as a platform neutral class name

Andrew John Hughes gnu.andrew at redhat.com
Tue May 28 16:50:35 UTC 2019



On 28/05/2019 13:30, Zhengyu Gu wrote:
> Hi,
> 
> Please review this backport to 8u. The patch applied largely clean after
> file path changes. But instead of using platform-dependent META-INFO
> service configuration file, I kept old mechanism to avoid pulling in
> more changesets, and updated service configuration in following files:
> 
> src/solaris/classes/sun/print/services/javax.print.PrintServiceLookup
> src/windows/classes/sun/print/services/javax.print.PrintServiceLookup
> 
> JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8055705
> Original patch: http://hg.openjdk.java.net/jdk9/client/jdk/rev/8278952344bc
> 
> JDK8u backport: http://cr.openjdk.java.net/~zgu/JDK-8055705-8u/webrev.00/
> 
> Thanks,
> 
> -Zhengyu

The webrev is not showing the file moves as renames, but as new files,
making it hard to compare to 11u. Your previous webrev for 8153732 had
it right.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the jdk8u-dev mailing list