RFR: 8176237 [backport]: (fs) java/nio/file/FileStore/Basic.java should conditionally check FileStores

Andrew John Hughes gnu.andrew at redhat.com
Tue May 28 20:50:55 UTC 2019



On 28/05/2019 16:21, Andrew Dinn wrote:
> I'd like to request a review for a backport of JDK-8176237 to jdk8u. The
> original patch does not apply cleanly. A modified patch is provided here:
> 
> changeset: http://cr.openjdk.java.net/~adinn/8176237/
> 
> 
> regards,
> 
> 
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
> 

The patch looks ok.

Do the patched tests pass?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the jdk8u-dev mailing list