RFR: 8202884 [backport]: SA: Attach/detach might fail on Linux if debugee application create/destroy threads during attaching

[Andrew Dinn]

On 28/05/2019 18:39, Andrew John Hughes wrote:
> This looks mostly like a clean backport apart from:
> 
> . . .
> It looks like the ATTACH_FAIL change has been lost and the
> ATTACH_THREAD_DEAD change moved to the block above. Was this deliberate?

No, that was most definitely an accident. Thank you for spotting it.

I could not test the patch (it is tricky to reproduce the error
scenario) but I did run a build. I was thinking "it ought not compile
with 'return false' in there" but unfortunately it does!

> Rest looks ok.
I'll have updated the patch in place. Is it ok now?

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander