[8u] RFR 8055705: Rename UnixPrintServiceLookup and Win32PrintServiceLookup as a platform neutral class name

[Andrew John Hughes]

On 30/05/2019 14:03, Zhengyu Gu wrote:
> 
> 
> On 5/30/19 8:57 AM, Andrew John Hughes wrote:
>>
>>
>> On 28/05/2019 19:46, Zhengyu Gu wrote:
>>>
>>
>>>
>>> Updated: http://cr.openjdk.java.net/~zgu/JDK-8055705-8u/webrev.01/
>>>
>>> Now, it shows moves.
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>>>>
>>
>> This version looks a lot better.
>>
>> Can you elaborate more on why the service file renames aren't included?
>> As far as I can tell, it should be possible to move
>>
>> src/solaris/classes/sun/print/services/javax.print.PrintServiceLookup
>> ->
>> src/share/classes/sun/print/services/javax.print.PrintServiceLookup
>>
>> jdk/src/solaris/classes/sun/print/service/javax.print.StreamPrintServiceFactory
>>
>> ->
>> jdk/src/share/classes/sun/print/services/javax.print.StreamPrintServiceFactory
>>
>>
>> and remove the Windows versions in the same way, avoiding what are now
>> identical files in windows and solaris subdirectories.
>>
>> I don't see the need to mirror the rename which adds META-INF into the
>> path, from 8054834 e.g.
>>
>> rename from
>> jdk/src/solaris/classes/sun/print/services/javax.print.PrintServiceLookup
>> rename to
>> jdk/src/java.desktop/unix/classes/META-INF/services/javax.print.PrintServiceLookup
>>
>>
>> rename from
>> jdk/src/solaris/classes/sun/print/services/javax.print.StreamPrintServiceFactory
>>
>> rename to
>> jdk/src/java.desktop/unix/classes/META-INF/services/javax.print.StreamPrintServiceFactory
>>
>>
>> rename from
>> jdk/src/windows/classes/sun/print/services/javax.print.PrintServiceLookup
>> rename to
>> jdk/src/java.desktop/windows/classes/META-INF/services/javax.print.PrintServiceLookup
>>
>>
>> rename from
>> jdk/src/windows/classes/sun/print/services/javax.print.StreamPrintServiceFactory
>>
>> rename to
>> jdk/src/java.desktop/windows/classes/META-INF/services/javax.print.StreamPrintServiceFactory
>>
> 
> Because we keep old (JDK8) service lookup mechanism, instead of
> migrating to newer one, which may need to pull in more changesets.
> 
> Thanks,
> 
> -Zhengyu
> 
> 
>>

I'm not suggesting changing the lookup mechanism, just dispensing with
duplicate copies of what are now the same file.

This worked for me on GNU/Linux with a small Makefile change:

https://cr.openjdk.java.net/~andrew/openjdk8/8055705/webrev.01/

Let me know if it works on Windows too.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew