Marlin renderer patches for jdk8u integration

Alvarez, David alvdavi at amazon.com
Mon Nov 4 18:21:16 UTC 2019


Hi,

We will do a TCK run, including interactive tests on Windows. We'll see if we do it on other platforms. 

--
David

On 2019-11-04, 02:36, "jdk8u-dev on behalf of Martijn Verburg" <jdk8u-dev-bounces at openjdk.java.net on behalf of martijnverburg at gmail.com> wrote:

    Hi all,
    
    We can apply these patches at AdoptOpenJDK and see if any of our test
    pipelines raise an issue if that would help?  This probably also needs a
    TCK check though.
    
    Cheers,
    Martijn
    
    
    On Sat, 2 Nov 2019 at 12:44, Laurent Bourgès <bourges.laurent at gmail.com>
    wrote:
    
    > Dear all,
    >
    > Here are the exact 21 patches backporting the Marlin renderer 0.9.1.3 to
    > jdk8u-dev:
    > - 19 patches (from zulu8) m01 to m19 from:
    > https://github.com/bourgesl/marlin-jdk8u/tree/master/marlin-zulu
    >
    > See my patch script:
    > https://github.com/bourgesl/marlin-jdk8u/blob/master/marlin-zulu/doPatch.sh
    >
    > - 2 new patches 8-m20 and 8-m21 from:
    >
    > https://github.com/bourgesl/marlin-jdk8u/tree/master/marlin-jdk/jdk8-patches
    >
    > See the 2nd patch script:
    > https://github.com/bourgesl/marlin-jdk8u/blob/master/marlin-jdk/doPatch.sh
    >
    > I applied cleanly patches on jdk8u-dev, made a clean build and performance
    > is good: marlin renderer is enabled by default, instead of the Pisces
    > renderer: up to 4x times faster in my benchmarks.
    >
    > See my simple build scripts:
    > https://github.com/bourgesl/marlin-jdk8u/blob/master/doGetOpenJDK8.sh
    > https://github.com/bourgesl/marlin-jdk8u/blob/master/doBuild.sh
    > Such linux x64 build is available (pure openjdk8u-dev oct 16th + patches)
    > for testing purposes:
    > https://github.com/bourgesl/marlin-jdk8u/releases/tag/v0.1
    >
    > FYI I prepared this backport and my review based on the following bug list:
    > https://github.com/bourgesl/marlin-jdk8u/blob/master/README.md
    >
    >
    > Finally I am ready to work with any jdk8u reviewer on the formal review
    > process (jdk8u label, individual patch RFR...).
    > Let me know how to proceed. Who could help me on the reviews and run
    > validation tests...
    >
    > Question: do you agree to enable the Marlin renderer by default in OpenJDK8
    > ? or prefer staying with the former Pisces renderer ? It consists in a few
    > line change in the RenderingEngine class.
    >
    > PS: I can copy all this material on cr.openjdk.java.net if necessary. Just
    > tell me.
    >
    > Cheers,
    > Laurent
    >
    



More information about the jdk8u-dev mailing list