[8u] RFR: 8233023: assert(Opcode() == mem->Opcode() || phase->C->get_alias_index(adr_type()) == Compile::AliasIdxRaw) failed: no mismatched stores, except on raw memory

[Severin Gehwolf]

On Wed, 2019-11-06 at 09:42 +0100, Roland Westrelin wrote:
> > > Isn't this:
> > > 
> > > @@ -3213,6 +3221,9 @@
> > >  // within the initialized memory.
> > >  intptr_t InitializeNode::can_capture_store(StoreNode* st, PhaseTransform* phase, bool can_reshape) {
> > >    const int FAIL = 0;
> > > +  if (st->is_unaligned_access()) {
> > > +    return FAIL;
> > > +  }
> > >    if (st->req() != MemNode::ValueIn + 1)
> > >      return FAIL;                // an inscrutable StoreNode (card mark?)
> > >    Node* ctl = st->in(MemNode::Control);
> > > 
> > > also missing from the 8140309?
> > 
> > It wasn't missing from the 8u backport of 8140309. See:
> > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/0ffee573412b
> > 
> > It was removed later by JDK-8202414.
> 
> Ok.
> 
> > Aah, good catch. I didn't mean to include part of 8080289. Updated
> > webrev:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8233023/02/webrev/
> 
> Looks good to me.

Thanks again for the review, Roland.

Cheers,
Severin