[8u] RFR for backport of 8198894 (CRC32 1/4): [PPC64] More generic vector CRC implementation (v2)

[Gustavo Romero]

Hello Martin,

On 11/07/2019 06:03 AM, Doerr, Martin wrote:
> Hi Gustavo,
> 
>> Good point, Martin. I overlooked the original change. It's a fix from Volker to
>> consider big-endian function descriptors when walking the stack:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8206173
>>
>> Fix applies cleanly (except for the path adjustment). It's shared code but in
>> effect it's PPC64-only. I'll take care of backporting it separate.
>>
>> And a nit in the test pointed out by Volker:
>>
>> http://hg.openjdk.java.net/jdk/jdk/file/5bc2e9c9604d/test/hotspot/jtreg/ru
>> ntime/ElfDecoder/TestElfDirectRead.java#l39
>>
>> It should read "function descriptors" instead of "file descriptors", right?
> 
> Comment fixes should not be done in backports. If you would like to fix it, it should get fixed in jdk/jdk and then backported.

Yeah, that's what I meant (implicitly at least). I'm aware of that. I plan to
fix it only in jdk/jdk, also the test is not part of Volker's fix, anyway I
think that nit is not worth a backport.


> Please backport as it is. You won't need a review if you don't change anything except the trivial path adaptations.

Yeah, that's why I mentioned it applied cleanly, except for path adaptations :)


Thanks.

Best regards,
Gustavo