[8u] RFR 8073108: Use x86 and SPARC CPU instructions for GHASH acceleration

[Hohensee, Paul]

Patch looks good. Have you run the tests on sparc?

Thanks,
Paul

On 11/20/19, 2:35 PM, "jdk8u-dev on behalf of Martin Balao" <jdk8u-dev-bounces at openjdk.java.net on behalf of mbalao at redhat.com> wrote:

    Hi,
    
    I'd like to request a review for the 8u backport of 8073108 [1].
    
    Webrev.00:
    
     * http://cr.openjdk.java.net/~mbalao/webrevs/8073108/8073108.8u.webrev.00/
    
    Differences from JDK patch:
    
    Hotspot
    --
    
     * Path changes
    
     * src/cpu/aarch64/vm/vm_version_aarch64.cpp
      * AArch64 changes do not apply to 8u
       * Will be proposed for
    http://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/
    
     * src/cpu/ppc/vm/vm_version_ppc.cpp
      * 1st hook does not apply cleanly because 8u has 8185979 [2] [3]
    already (8185979 is newer than 8073108 but was backported first).
    Manually applied change without further conflicts.
    
     * src/cpu/x86/vm/assembler_x86.cpp
      * 1st hook does not apply cleanly because 8u does not have 8076276
    [4]. Manually applied changes without further conflicts.
    
     * src/share/vm/runtime/globals.hpp
      * 1st hook does not apply cleanly because 8u does not have 8074459
    [5]. Manually applied changes without further conflicts.
    
    JDK
    --
    
     * Path changes
    
    Testing:
    
     * com/sun/crypto/provider/Cipher/AES/TestGHASH.java
      * Passes
    
     * hotspot/test/compiler/7184394
      * Passes
    
    Thanks,
    Martin.-
    
    --
    [1] - https://bugs.openjdk.java.net/browse/JDK-8073108
    [2] - https://bugs.openjdk.java.net/browse/JDK-8185979
    [3] - http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/c4567d28f31f
    [4] - https://bugs.openjdk.java.net/browse/JDK-8076276
    [5] - https://bugs.openjdk.java.net/browse/JDK-8074459