[8u] RFR 8170641: sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails with timeout
Hohensee, Paul
hohensee at amazon.com
Fri Nov 22 00:20:17 UTC 2019
Patch looks fine. Note that this is just a code review, not an approval (also of course the case for my previous reviews). I'm not a maintainer, not do I wish to be one. :)
Paul
On 11/21/19, 11:03 AM, "jdk8u-dev on behalf of Martin Balao" <jdk8u-dev-bounces at openjdk.java.net on behalf of mbalao at redhat.com> wrote:
Hi,
I'd like to request a review for the 8u backport of 8170641 [1].
Webrev.00:
*
http://cr.openjdk.java.net/~mbalao/webrevs/8170641/8170641.8u.jdk.webrev.00/
Differences from JDK baseline patch:
* Path changes
*
test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh
*
test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh
* Hooks do not apply cleanly because 8142968 [2] is not in 8u.
Manually applied the changes (which was removing the files)
*
test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.java
*
test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.java
* Removed "@modules" and "@library" from jtreg headers
* @library has to be /lib/testlibrary in 8u
* Set correct imports for OutputAnalyzer and ProcessTools (which are
located in jdk.testlibrary instead of jdk.test.lib.process)
Testing:
*
test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.java
* Passes
*
test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.java
* Passes
This backport would bring parity between OpenJDK and Oracle JDK.
Thanks,
Martin.-
--
[1] - https://bugs.openjdk.java.net/browse/JDK-8170641
[2] - https://bugs.openjdk.java.net/browse/JDK-8142968
More information about the jdk8u-dev
mailing list