[8u] RFR 8073108: Use x86 and SPARC CPU instructions for GHASH acceleration

Hohensee, Paul hohensee at amazon.com
Fri Nov 22 16:07:09 UTC 2019


I'm fine with your proposal to go ahead with 8073108 and do 8130341 next. Now we just need sparc verification. If we don't get that in the next day or two, then I'm ok with pushing just x32/64. Sparc can be done later.

Thanks,
Paul

On 11/21/19, 9:04 PM, "Martin Balao" <mbalao at redhat.com> wrote:

    Hi Paul,
    
    On 11/21/19 12:48 PM, Hohensee, Paul wrote:
    > You should be able to build a 32-bit linux jdk and test it on x32.
    
    The following tests are passing in x86 32 bits (Linux):
    
     * jdk/test/com/sun/crypto/provider/Cipher/AES/TestGHASH.java
    
    The following tests are failing in x86 32 bits (Linux):
    
     * hotspot/test/compiler/7184394/TestAESMain.java
    
    The reason why TestAESMain fails is that there is a known bug fixed by
    8130341 [1]. I've applied my 8u backport of 8130341 [1] and can confirm
    that the test passes. So I suggest not to block the 8u backport of
    8073108 and proceed with a 8u backport of 8130341 thereafter.
    
    Note: a 8u backport of 8130341 has been proposed by Yuri Gaevsky here:
    http://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-October/010437.html This
    backport is identical to mine (except for the commit headers which were
    not included in Yuri's patch).
    
    Thanks,
    Martin.-
    
    --
    [1] - https://bugs.openjdk.java.net/browse/JDK-8130341
    
    



More information about the jdk8u-dev mailing list