Request for approval: JDK-8130341 "GHASH 32bit intrinsics has AEADBadTagException"

[Doerr, Martin]

Hi Yuri,

reviewed and added jdk8u-fix-request.

Best regards,
Martin


> -----Original Message-----
> From: Yuri Gaevsky <ygaevsky at azul.com>
> Sent: Dienstag, 26. November 2019 11:25
> To: jdk8u-dev at openjdk.java.net; Doerr, Martin <martin.doerr at sap.com>
> Subject: RE: Request for approval: JDK-8130341 "GHASH 32bit intrinsics has
> AEADBadTagException"
> 
> Since SPARC testing for 8073108 (thanks a lot, Martin!) is now completed,
> can we have the 8130341 backport reviewed too?
> 
> Thanks,
> -Yuri
> 
> -----Original Message-----
> From: jdk8u-dev [mailto:jdk8u-dev-bounces at openjdk.java.net] On Behalf
> Of Yuri Gaevsky
> Sent: Monday, October 28, 2019 05:13 PM
> To: jdk8u-dev at openjdk.java.net
> Subject: FW: Request for approval: JDK-8130341 "GHASH 32bit intrinsics has
> AEADBadTagException"
> 
> ping.
> 
> -----Original Message-----
> From: jdk8u-dev [mailto:jdk8u-dev-bounces at openjdk.java.net] On Behalf
> Of Yuri Gaevsky
> Sent: Thursday, October 10, 2019 12:52 PM
> To: jdk8u-dev at openjdk.java.net
> Subject: Request for approval: JDK-8130341 "GHASH 32bit intrinsics has
> AEADBadTagException"
> 
> Hello,
> 
> Please approve backport of JDK-8130341 "GHASH 32bit intrinsics has
> AEADBadTagException"
> to jdk8u which is a required follow-up fix for the issue mentioned in [1].
> 
> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8130341
> 
> JDK9 review thread:
>   http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-
> July/018402.html
> JDK9 changeset:
>   http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/36fd5d1982b0
> 
> Webrev:
>   http://cr.openjdk.java.net/~ygaevsky/8130341.8u/webrev.hotspot/
>   NB: The original change for JDK9 does apply cleanly to jdk8u codebase w/
>   minor correction to the test path (test/compiler/codegen/7184394/ -->
>   test/compiler/7184394/).
> 
> Testing:
>   windows-i586: (known failures mentioned in [1] are gone)
>   windows-x64:
>     JTREG tests:
>       (jdk8u) hotspot/test/compiler/7184394/
>       (jdk8u) jdk/test/com/sun/crypto/provider/Cipher/AES/
>     (also checked the output from TestAESMain for performance
> improvements w/
>      -XX:+UseGHASHIntrinsics)
> 
> Thank you,
> -Yuri Gaevsky, Azul Systems, Inc.
> 
> [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-
> October/010409.html