[8u] RFR 8185898: setRequestProperty(key, null) results in HTTP header without colon in request

Hohensee, Paul hohensee at amazon.com
Wed Nov 27 16:00:55 UTC 2019


Looks good. :)

On 11/26/19, 10:36 PM, "Yuri Nesterenko" <yan at azul.com> wrote:

    Oops, indeed. Thank you Paul!
    
    For consistency, resent
    http://cr.openjdk.java.net/~yan/8185898/webrev.1/ without that comment.
    
    --yan
    
    On 26.11.2019 19:40, Hohensee, Paul wrote:
    > Looks fine, except remove the @modules comment from the test, because there are no modules in 8.
    >
    > Thanks,
    > Paul
    >
    > On 11/26/19, 4:47 AM, "jdk8u-dev on behalf of Yuri Nesterenko" <jdk8u-dev-bounces at openjdk.java.net on behalf of yan at azul.com> wrote:
    >
    >     Hi,
    >     
    >     please review this request for a backport to 8u.
    >     
    >     Original issue:
    >     
    >         https://bugs.openjdk.java.net/browse/JDK-8185898
    >     
    >         https://hg.openjdk.java.net/jdk/jdk/rev/0211b062843d
    >     
    >     The patch itself applied good enough; I had to adapt the test for JDK8.
    >     
    >     Look for webrev here:
    >     
    >         http://cr.openjdk.java.net/~yan/8185898/webrev.0/
    >     
    >     Thank you!
    >     
    >     --yan
    >     
    >     
    >     
    >
    
    



More information about the jdk8u-dev mailing list