[8u] RFR 8055351: sun/security/provider/DSA/TestAlgParameterGenerator.java failed with interrupted! (timed out?)

[Andrew John Hughes]

On 20/11/2019 19:32, Martin Balao wrote:
> Hi,
> 
> I'd like to request a review for the 8u backport of 8055351 [1].
> 
> Webrev.00:
> 
>  *
> http://cr.openjdk.java.net/~mbalao/webrevs/8055351/8055351.8u.jdk.webrev.00/
> 
> Differences from JDK baseline patch:
> 
>  * test/sun/security/provider/DSA/TestAlgParameterGenerator.java
>   * Copyright date
>   * 1st and 2nd hooks do not apply cleanly because 8u already has
> 8181048 [2] [3] affecting the same file. Note: 8181048 was backported
> before 8055351 to 8u, even though it's a newer patch. Manually applied
> changes without further conflicts.
> 
> Testing:
> 
>  *  sun/security/provider/DSA/TestAlgParameterGenerator.java passes
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8055351
> [2] - https://bugs.openjdk.java.net/browse/JDK-8181048
> [3] - http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/65f4af74c8b1
> 

Why is the copyright being changed here? The 8u version is already later
than the change in this patch (presumably from 8181048), so can just be
left alone. By changing it to 2019, you're creating a change unique to
8u which will has the potential to cause problems for other backports.

Otherwise looks fine.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew