[8u] RFR 8208715: Conversion of milliseconds to nanoseconds in UNIXProcess contains bug

Hohensee, Paul hohensee at amazon.com
Mon Oct 21 16:10:14 UTC 2019


Fixed, see http://cr.openjdk.java.net/~phh/8208715/webrev.01/.

Thanks for the review!

Paul

From: Martin Buchholz <martinrb at google.com>
Date: Saturday, October 19, 2019 at 6:57 AM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: "Guo, James" <junguoj at amazon.com>, "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
Subject: Re: [8u] RFR 8208715: Conversion of milliseconds to nanoseconds in UNIXProcess contains bug



On Wed, Sep 25, 2019 at 5:58 PM Hohensee, Paul <hohensee at amazon.com<mailto:hohensee at amazon.com>> wrote:
Ping (it's been nearly a month :)).

I posted an updated webrev at

http://cr.openjdk.java.net/~phh/8208715/webrev.00/

This backport Looks Good To Me.

I did notice one gratuitous difference.
https://hg.openjdk.java.net/jdk/jdk/rev/41257a58a588
The original change deleted this line:
-            // Round up to next millisecond
but the backport failed to do the same.  I would fix that.



More information about the jdk8u-dev mailing list