[8u] RFR for backport of 8198894 (CRC32 1/4): [PPC64] More generic vector CRC implementation

[Doerr, Martin]

Hi Gustavo,

I think removing invertCRC is an unnecessary manual change.
We should minimize that as far as possible. They may create merge conflicts for future backports.

Best regards,
Martin


> -----Original Message-----
> From: Gustavo Romero <gromero at linux.vnet.ibm.com>
> Sent: Mittwoch, 23. Oktober 2019 23:36
> To: Doerr, Martin <martin.doerr at sap.com>; hotspot-compiler-
> dev at openjdk.java.net
> Cc: jdk8u-dev at openjdk.java.net
> Subject: Re: [8u] RFR for backport of 8198894 (CRC32 1/4): [PPC64] More
> generic vector CRC implementation
> 
> Hi Martin,
> 
> On 10/22/2019 11:37 AM, Doerr, Martin wrote:
> > Hi Gustavo,
> >
> > backport looks good. The parts you have collected from other changes
> make sense to me.
> 
> Thank you so much for the review.
> 
> Should I consider patches 2, 3, and 4/4 [0, 1, 2] reviewed too? (since they are
> part of the CRC32 patchset)
> 
> I intend to push 1, 2, 3, and 4 at the same time to jdk8u, but there is no
> harm too if they are not applied at once, it won't break the CRC32 or the
> JVM.
> 
> I know that patchset is not small, so I really appreciate your time reviewing
> the patches. Thank you.
> 
> Best regards,
> Gustavo
> 
> [0] https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2019-
> September/035219.html
> [1] https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2019-
> September/035221.html
> [2] https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2019-
> September/035220.html