RFR for backport of JDK-8034773 : (zipfs) newOutputstream uses CREATE_NEW when no options specified

Langer, Christoph christoph.langer at sap.com
Tue Oct 29 08:24:43 UTC 2019


Hi Jaikiran,

the backport looks good to me. I can sponsor it, once we get the approval label.

Yes, it's really weird that in JDK8 the zipfs coding was still located in the demo folder though it actually belonged to the product. But that's how it is ��

Cheers
Christoph

> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-bounces at openjdk.java.net> On Behalf Of
> Jaikiran Pai
> Sent: Dienstag, 29. Oktober 2019 08:44
> To: jdk8u-dev at openjdk.java.net
> Subject: RFR for backport of JDK-8034773 : (zipfs) newOutputstream uses
> CREATE_NEW when no options specified
> 
> Can I please get a review and a sponsor for a fix which backports
> JDK-8034773 [1] to OpenJDK 8? The backport is available as a webrev at
> [2]. The JBS issue tracking this backport is at [3].
> 
> The commit in this backport patch was manually created since the
> original commit for [1] does not apply cleanly because of the directory
> structure changes between the 8u repo and the later JDK repos. This
> change along with the test case introduced in the original commit,
> passed locally.
> 
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8034773
> 
> [2] https://cr.openjdk.java.net/~jpai/webrev/8233103/1/webrev/
> 
> [3] https://bugs.openjdk.java.net/browse/JDK-8233103
> 
> P.S: Bit surprised that in JDK 8, the source for nio/zipfs resided in
> "demo" directory and even has a warning stating the code is for demo
> purpose.
> 
> -Jaikiran
> 



More information about the jdk8u-dev mailing list