Request for Approval: Backport of 8231988 : Unexpected test result caused by C2 IdealLoopTree::do_remove_empty_loop

[Andrew John Hughes]

On 29/10/2019 00:53, Yangfei (Felix) wrote:
> Hi,
> 
> 
> 
> May I got review for the backport of 8231988 to 8u master repo please?  This fixes a C2 bug which is level P2.
> 
> 

Ok, but then the subject for this mail should really be 'Request for
Review' (or RFR for short) :-)

Approvals don't require an e-mail. Labelling the bug 'jdk8u-fix-request'
and providing an explanation in the comments (as I see you have for this
bug) is sufficient.

> 
> Patch does not apply cleanly to 8u due to file path difference.
> 
> Webrev: http://cr.openjdk.java.net/~fyang/8231988-8u-backport/webrev.00/
> 

That's acceptable without a review and is true of all backports from >=9.

I see other changes were also made here as well, altering a copyright
header and removing the package declaration from the test case.

> 
> 
>        Bug: https://bugs.openjdk.java.net/browse/JDK-8231988
>        Upstream Changeset: https://hg.openjdk.java.net/jdk/jdk/rev/45a085445a8c
> 
> New test fails without the patch, and passes with it.
> Jtreg test pass with the patch.

Confirmed with my own testing.

Patch looks fine. Approved and pushed.

> 
> 
> Thanks,
> Felix
> 

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew