[8u] RFR: 8134739: compiler/loopopts/superword/TestVectorizationWithInvariant crashes in loop opts

[Andrew John Hughes]

On 25/10/2019 13:04, Aleksey Shipilev wrote:
> On 10/9/19 9:59 AM, Roland Westrelin wrote:
>> http://cr.openjdk.java.net/~roland/8134739.8u/webrev.00/
> 
> Backport looks good.
> 
> So the only conflict in jdk8u-dev right now is different "phi()" in loopnode.hpp, and superword.cpp
> actually applies without conflicts, right? I was staring into superword.cpp trying to see the
> difference, and there does not seem to be any.
> 

No difference for me either in comparing the two patches.

The meat of this is slightly obscured by the original author deciding it
would be a good time to move the position of the '*' in a number of
statements, making that the only change in some lines. The actual change
is to filter out some scenarios by returning NULL.

Looks fine to me.

Approved.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew