[8u] 8178870: instrumentation.retransformClasses cause coredump

[Andrew John Hughes]

On 23/08/2019 13:13, Zhengyu Gu wrote:
> Hi Aleksey,
> 
> On 8/20/19 11:57 AM, Aleksey Shipilev wrote:
>> On 8/20/19 5:44 PM, Zhengyu Gu wrote:
>>> On 8/20/19 10:23 AM, Aleksey Shipilev wrote:
>>>> On 8/19/19 9:14 PM, Zhengyu Gu wrote:
>>>>> 8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8178870-8u/webrev.00/
>>>>
>>>> Backport looks good.
>>
>> I just noticed your other backport has the new definition of get_ik here:
>>
>> http://cr.openjdk.java.net/~zgu/JDK-8155951-8u/webrev.00/src/share/vm/prims/jvmtiRedefineClasses.cpp.sdiff.html
>>
>>
>> Maybe you want to commit them in more convenient order to get the
>> definition in for this backport.
> 
> Nice catch! Updated webrev to reflect the order and eliminate the extra
> get_ik().
> 
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8178870-8u/webrev.01/
> 
> Thanks,
> 
> -Zhengyu
> 
> 
> 
>>

This seems to contain 3 bug IDs. Please post a clean webrev for 8178870
once 8155951 is pushed.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew