RFC: backport JDK-8139965: Hang seen when using com.sun.jndi.ldap.search.replyQueueSize

[Andrew John Hughes]

On 29/08/2019 10:58, Mario Torre wrote:
> Hi,
> 
> I would like to backport the following bug:
> 
> https://bugs.openjdk.java.net/browse/JDK-8139965
> 
> The backport is based on the 11u patch rather than the original, for
> similar reasons as highlighted here:
> 
> https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-June/001257.html
> 
> The patch applied mostly cleanly, however some manual reshuffling was
> necessary, here the request for review:
> 
> http://cr.openjdk.java.net/~neugens/8139965/webrev.00/
> 
> Cheers,
> Mario
> 

It doesn't apply cleanly because of two contextual differences:

1.

@@ -75,7 +75,7 @@
 -                        } else {
 -                            // no timeout is set so we wait infinitely
until
 -                            // a response is received
--                            //
http://docs.oracle.com/javase/8/docs/technotes/guides/jndi/jndi-ldap.html#PROP
+-                            //
https://docs.oracle.com/javase/8/docs/technotes/guides/jndi/jndi-ldap.html#PROP
 -                            ldr.wait();
 -                        }
 -                    } else {

This is because of "8068491: Update the protocol for references of
docs.oracle.com to HTTPS" [0] which has oddly only ever been applied to
a branch of 8u and isn't in 9+.

2.

@@ -191,7 +191,7 @@
 +    }

 -        // Unblock reader of pending request
--        // Should only ever have at most one waiter
+-        // Should only ever have atmost one waiter
 -        notify();
 +    synchronized void close() {
 +        closed = true;

This is because 8u lacks "8054158: Fix typos in JNDI-related packages"
which is probably worth backporting at some point.

There did seem to be some other odd whitespace differences in your
patch, so I did a clean backport from 11u and pushed the result.

[0] https://bugs.openjdk.java.net/browse/JDK-8068491
[1] https://bugs.openjdk.java.net/browse/JDK-8054158

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew