[8u] RFR Backport JDK-8154313, Generated javadoc scattered all over the place

[Jiri Vanek]

On 9/2/19 6:55 PM, Severin Gehwolf wrote:
> On Mon, 2019-09-02 at 18:39 +0200, Jiri Vanek wrote:
>>> make/Main.gmk:
>>>
>>>   202 # Remove everything, except the output from configure.
>>>   203 clean: clean-langtools clean-corba clean-jaxp clean-jaxws clean-hotspot clean-jdk clean-nashorn clean-images clean-overlay-images clean-bootcycle-build clean-docs clean-docs-zip clean-test
>>>
>>> You are adding clean-docs-zip to the default "clean" target. Yet, "make
>>> docs" doesn't seem to build docs-zip. That seems inconsistent. I'd
>>> require an explicit "make clean-docs-zip" call. I.e. don't add it to
>>> the list of dep-targets for "make clean".
>>
>> Isn't maybe better to add docs-zip to default docs target?
> 
> I'm not sure. My concern is about people who are using "make docs" now
> and not breaking their use-cases. Even if that just means longer build
> time in reality. It's not unreasonable to assume "make docs" is
> potentially more widely used. As docs-zip is new, it cannot be used.
> I'd error on the side of caution for both cases: "make clean" and "make
> docs".
> 

fair enough. Ty!
> Thanks,
> Severin
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109