Request for Approval: Backport of 8147611: G1 - Missing memory barrier in start_cset_region_for_worker

[Andrew John Hughes]

On 10/06/2019 13:47, Yangfei (Felix) wrote:
> Hi,
> 
> 
> 
> Please approve the backport of 8147611 to 8u-dev.
> 
> This bug is biting one of our product which is based on the aarch64 Linux platform.
> 
>     As the patch changes shared code, it's better to backport it to the jdk8u master repo first.
> 
> 
> 
>     Bug: https://bugs.openjdk.java.net/browse/JDK-8147611
> 
>     JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/8fcd5cba7938
> 
> 
> 
>     The code change is trivial and should be easy for it to be applied to the jdk8u master repo.
> 
> 
> 
> Thanks,
> 
> Felix
> 

There doesn't seem to be a patch here for review.

I applied the 11u version and the hunk had to be manually applied
instead because of whitespace differences.

I've pushed it now, but in future, cases like this should be posted for
review before seeking approval. Skipping the review process is only
applicable when the patch applies cleanly, after file paths are adjusted.

The fix request comment on the bug should detail whether it applies
cleanly or not, and link to a review thread if not.

Also note that I gave approval for this on 2019-06-12, but it has never
been committed in the subsequent two and half months.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew