[8u] [jfr] RFR 8230707: JFR related tests are failing

[Jaroslav Bachorík]

I have removed all the TODOs and commented out lines -
http://cr.openjdk.java.net/~jbachorik/8230707/jdk/webrev.01/

-JB-

On Tue, Sep 10, 2019 at 2:54 PM Jaroslav Bachorík <
jaroslav.bachorik at datadoghq.com> wrote:

> Hi Mario,
>
> thanks for the comments. I left in the comments because I wanted to avoid
> a situation when we remove the tests now because of lacking implementation
> and then when the implementation is added nobody will remember to modify
> JFR tests back.
> Not sure what is the correct process for this. Thing is that the missing
> stuff is quite heavy weight and would ideally be ported by someone with
> good understanding of the backported feature as JDK 8 implementation will
> differ significantly.
>
> Anyway, if the correct way is just to remove non-functional, commented out
> lines I will do it, no problem.
>
> Cheers,
>
> -JB-
>
> On Tue, Sep 10, 2019 at 11:38 AM Mario Torre <
> neugens.limasoftware at gmail.com> wrote:
>
>> Hi Jaroslav,
>>
>> Thanks for the patch. I think there are a number of commented out
>> lines and "TODOs", we should probably remove them instead. If the test
>> do not apply, we should remove the test, otherwise a fix may be
>> necessary, but we can't push commented out code.
>>
>> The patch itself seems generally good, I guess we should only remove
>> the commented code instances and it's ok to push?
>>
>> Cheers,
>> Mario
>>
>> Il giorno mar 10 set 2019 alle ore 10:57 Jaroslav Bachorík
>> <jaroslav.bachorik at datadoghq.com> ha scritto:
>> >
>> > JIRA:      https://bugs.openjdk.java.net/browse/JDK-8230707
>> > Webrev: http://cr.openjdk.java.net/~jbachorik/8230707/
>> >
>> > Please, review this test-only change to JFR related tests which were
>> > brought in as a part of the JFR backport effort. Due to differences in
>> GC,
>> > runtime, compiler, etc. implementations between JDK 8 and JDK 9+ some
>> tests
>> > need updating or complete removal.
>> >
>> > The most significant differences:
>> > - no segmented code cache
>> > - no G1 IHOP
>> > - G1 emits serial old event instead G1 full
>> > - no CI and compilation directives
>> > - no unified logging
>> >
>> > The changes are usually quite trivial (removing the offending JVM arg or
>> > removing test relying on non-existent features).
>> >
>> > With these changes in place all jdk_jfr tests are passing.
>> >
>> > Cheers,
>> >
>> > -JB-
>>
>>
>>
>> --
>> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
>> Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF
>>
>> Java Champion - Blog: http://neugens.wordpress.com - Twitter: @neugens
>> Proud GNU Classpath developer: http://www.classpath.org/
>> OpenJDK: http://openjdk.java.net/projects/caciocavallo/
>>
>> Please, support open standards:
>> http://endsoftpatents.org/
>>
>