[8u] RFR 8225425: java.lang.UnsatisfiedLinkError: net.dll: Can't find dependent libraries

[Chris Hegarty]

Aleksey,

On 10/09/2019 19:47, Aleksey Shipilev wrote:
> Original bug:
>    https://bugs.openjdk.java.net/browse/JDK-8230573
>    https://hg.openjdk.java.net/jdk/jdk/rev/56df9a08ed9c
> 
> 11u fix (would be handy for URIBuilder, see below):
>    https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/343f922e2fbe
> 
> This is in 8u231, so it is important to get it into jdk8u232. Ivan, Chris, can you eyeball it too,
> please?
> 
> The patch does not apply cleanly, because build system is different, the context is different, test
> library layout is different, URIBuilder is not there, etc.
> 
> 8u webrev:
>    https://cr.openjdk.java.net/~shade/8225425/webrev.8u.01/

Looks fine.

> Notable changes w.r.t. original fix:
> 
>   *) The build system fix goes into make/lib/NetworkingLibraries.gmk, not in make/lib/Lib-java.base.gmk
> 
>   *) src/java.base/windows/native/libnet/NTLMAuthentication.c failed to apply, because "LPCWSTR
> bstrURL;" was in context. Had to reapply the entire patch to that file by hand.
> 
>   *) test/lib/jdk/test/lib/net/URIBuilder.java put into location that fits 8u.
> 
>   *) test/sun/net/www/protocol/http/TestTransparentNTLM.java has several changes:
> 
>   Fit new location of URIBuilder:
>     30  * @library ../../../../../lib/
> 
>   Read the InputStream without readAllBytes method (added in 9):
>    85             InputStream is = uc.getInputStream();
>    86             byte[] buf = new byte[1024];
>    87             while (is.read(buf) != -1) {};

These changes w.r.t. original fix, seem reasonable.

-Chris.