[8u] 8222108: Reduce minRefreshTime for updating remote printer list on Windows

[Andrew John Hughes]

On 03/09/2019 13:56, Zhengyu Gu wrote:
> 
> 
> On 9/3/19 1:12 AM, Andrew John Hughes wrote:
>>
>>
>> On 27/08/2019 14:39, Zhengyu Gu wrote:
>>>
>>> I would like to backport this patch to 8u, as it is in Oracle's 8u.
>>>
>>> The patch does not apply cleanly. In early backports, there were
>>> conflicts and we kept 8u code in old styles.
>>>
>>> E.g. RemotePrinterChangeListener still inherits from Thread, instead of
>>> implementing Runnable in new code.
>>>
>>> Original bug: https://bugs.openjdk.java.net/browse/JDK-8222108
>>> Original code review threads:
>>> Code review threads:
>>> http://mail.openjdk.java.net/pipermail/2d-dev/2019-June/010153.html
>>> http://mail.openjdk.java.net/pipermail/2d-dev/2019-July/010169.html
>>> http://mail.openjdk.java.net/pipermail/2d-dev/2019-August/010235.html
>>>
>>> 8u Webrev: http://cr.openjdk.java.net/~zgu/JDK-8222108-8u/webrev.00/
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>
>> This mostly looks ok, but one change seems to have been missed; the
>> prevRemotePrinters variable is not removed. Was there a reason for this?
> 
> My bad.
> 
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8222108-8u/webrev.01/
> 
> Retested on Windows x86_64
> 
> Thanks,
> 
> -Zhengyu
> 

Looks good.

As this is one of the fixes we still intend to get into 8u232, please
flag the bug with jdk8u-critical-request and then push to
https://hg.openjdk.java.net/jdk8u/jdk8u/jdk when approved.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew