[8u] RFR Backport of 8067429: java.lang.VerifyError: Inconsistent stackmap frames at branch target

[Andrew Leonard]

fyi,
I couldn't find an obvious How to contribute doc for jdk8u, so I was 
following the jdk11u one here inserting jdk8u...: 
https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix
I infered from this since I had to modify the patch to backport to jdk8 
from jdk9, even though it's just path changes, I needed a review...
Thanks
Andrew

Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leonard at uk.ibm.com 




From:   Andrew John Hughes <gnu.andrew at redhat.com>
To:     Andrew Leonard <andrew_m_leonard at uk.ibm.com>, 
jdk8u-dev at openjdk.java.net
Date:   16/09/2019 15:06
Subject:        Re: [8u] RFR Backport of 8067429: java.lang.VerifyError: 
Inconsistent stackmap frames at branch target





On 12/08/2019 17:15, Andrew Leonard wrote:
> Hi,
> Please can I request a review of this updated patch for 8067429 to
> backport to jdk8u/langtools. We have seen problem reports from clients
> seeing this issue with jdk8 and would like to request a backport please.
> The patch is essentially the same as published to jdk9+, but jdk8 the 
file
> paths are in a different location. I have built and tested all "tier1" 
and
> "langtools_all" successfully, and the patch new testcase passes.
> 
https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Ealeonard_8067429_webrev.00&d=DwIFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=NaV8Iy8Ld-vjpXZFDdTbgGlRTghGHnwM75wUPd5_NUQ&m=DQLrWqQFPORmCxvDo8h106uWUooNVYZ_Fo19Ilr4xj0&s=QEg9D0wG_S6KQwQLdlw-Khs2AEwuHsps5TCqmEz1k-I&e= 

> Once reviewed I will add the jdk8u-fix-request.
> 
> Many thanks
> Andrew
> 
> 
> Andrew Leonard
> Java Runtimes Development
> IBM Hursley
> IBM United Kingdom Ltd
> internet email: andrew_m_leonard at uk.ibm.com
> 
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 
3AU
> 

This is a clean backport (once paths are fixed using the 
jdk9/common/bin/unshuffle_patch.sh script) so there is no need for 
review, only approval.

I've pushed the original version of this fix, without the unnecessary 
copyright changes that seem to be in your webrev:

https://urldefense.proofpoint.com/v2/url?u=https-3A__hg.openjdk.java.net_jdk8u_jdk8u-2Ddev_langtools_rev_f02d967ddce2&d=DwIFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=NaV8Iy8Ld-vjpXZFDdTbgGlRTghGHnwM75wUPd5_NUQ&m=DQLrWqQFPORmCxvDo8h106uWUooNVYZ_Fo19Ilr4xj0&s=H00jdHCuHkeTcoxKzYqFLixgh9sugWpgC0jN0lBvl_s&e= 


Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (
https://urldefense.proofpoint.com/v2/url?u=http-3A__www.redhat.com&d=DwIFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=NaV8Iy8Ld-vjpXZFDdTbgGlRTghGHnwM75wUPd5_NUQ&m=DQLrWqQFPORmCxvDo8h106uWUooNVYZ_Fo19Ilr4xj0&s=4tqi9529StPHiytZmw4obcA8v0-WmPnEdZloGSjgRs0&e= 
)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://urldefense.proofpoint.com/v2/url?u=https-3A__keybase.io_gnu-5Fandrew&d=DwIFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=NaV8Iy8Ld-vjpXZFDdTbgGlRTghGHnwM75wUPd5_NUQ&m=DQLrWqQFPORmCxvDo8h106uWUooNVYZ_Fo19Ilr4xj0&s=WfyHottZ9FUhRo0Hmp55lnf465M4zs01QiIzFDn4z3c&e= 






Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU