[8u] RFR 8225425: java.lang.UnsatisfiedLinkError: net.dll: Can't find dependent libraries

[Andrew John Hughes]

On 23/09/2019 09:03, Aleksey Shipilev wrote:
> On 9/23/19 7:55 AM, Andrew John Hughes wrote:
>> On 16/09/2019 12:40, Aleksey Shipilev wrote:
>>> On 9/12/19 4:55 AM, Andrew John Hughes wrote:
>>>> Why is this being backported as part of this and not a backport of
>>>> https://bugs.openjdk.java.net/browse/JDK-8220575 which would also mean
>>>> we get the advantages of introducing this helper class in other tests?
>>>
>>> Because this is a critical bugfix, and we don't want to pull in more that necessary. It also matches
>>> what was done in 11u.
>>
>> I'm not sure that's a great reason to do a rushed job. And I would have
>> said the same for 11, FWIW.
> 
> Granted, English is not my mother tongue, but the dictionary says "rushed job" implies this is done
> without care. However, this patch is done with care to minimize test dependencies pushed to
> stabilizing tree. For the regular backport with the weeks of spare time ahead, I would bring more
> dependencies that can be tested more thoroughly; but this one is not a regular backport.
> 

Sorry, that wasn't my implication, but I admit the phrase can be used
with negative connotations. I concur with what you're saying that you'd
do things differently if there was more time:

"We need to do X, Y and Z to get the job done"

"I need it by Friday"

"Ok, we can do just X and Z, but it'll be a rush job"

i.e. in the sense it's not what I'd do under normal circumstances.

At the time of the original request, I thought there was time for what
is just a testcase update. Now we're freezing this Wednesday, I'm
grudgingly waving it through.

I know I make a fuss about things like this, but I also know the pain of
finding your clean backport has been messed up by some file appearing
largely unexplained in a different changeset :-)

>> At the very least, it should be flagged for later backport.
> 
> Flagged.
> 
>> Approved for 8u.
> 
> Pushed.
> 

Thanks for the quick turnaround.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew