[8u] 8178870: instrumentation.retransformClasses cause coredump

[Alvarez, David]

Hi,

After importing jdk8u232-b06 we are seeing two new failures in jtreg apparently
caused by this change.

Affected tests are:
runtime/RedefineTests/test8178870.sh
runtime/RedefineTests/RedefineDoubleDelete.java

test8178870.sh fails because it is defined as test.sh in the jtreg section.
Fixing this will allow the test to run, but it will still fail later with a
ClassNotFoundException.

RedefineDoubleDelete will fail during compilation locating RedefineClassHelper
as it does not have @library defined, but after adding it will still fail with
an NPE.

--
David Alvarez


On 2019-09-12, 09:47, "jdk8u-dev on behalf of Andrew John Hughes" <jdk8u-dev-bounces at openjdk.java.net on behalf of gnu.andrew at redhat.com> wrote:

    
    
    On 12/09/2019 13:28, Zhengyu Gu wrote:
    
    snip...
    
    >>>>
    >>
    >> This looks ok. I presume you intend to commit with the correct metadata,
    >> as currently it says "imported patch JDK-8178870_coredump.patch"?
    > 
    > Of course. Otherwise, it won't push.
    > 
    
    Running jcheck locally [0], I can't even commit something like that :)
    
    Just wanted to be sure.
    
    [0] https://openjdk.java.net/projects/code-tools/jcheck/
    
    Thanks,
    -- 
    Andrew :)
    
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
    https://keybase.io/gnu_andrew