[8u] 8178870: instrumentation.retransformClasses cause coredump

[Zhengyu Gu]

Hi David,

Do you still have problems other than the wrong test name?

Andrew, Aleksey:

What's the process to fix this bad test? Sorry for the troubles.

Thanks,

-Zhengyu


On 9/24/19 8:18 AM, Zhengyu Gu wrote:
> 
> 
> On 9/23/19 9:07 PM, Alvarez, David wrote:
>> Hi,
>>
>> After importing jdk8u232-b06 we are seeing two new failures in jtreg 
>> apparently
>> caused by this change.
>>
>> Affected tests are:
>> runtime/RedefineTests/test8178870.sh
>> runtime/RedefineTests/RedefineDoubleDelete.java
>>
>> test8178870.sh fails because it is defined as test.sh in the jtreg 
>> section.
> Oops, I did make stupid last minute name change. But other than that, 
> test runs fine for me.
> 
> diff -r 7d5c800dae75 test/runtime/RedefineTests/test8178870.sh
> --- a/test/runtime/RedefineTests/test8178870.sh Tue Sep 10 19:58:22 2019 
> +0200
> +++ b/test/runtime/RedefineTests/test8178870.sh Tue Sep 24 08:17:05 2019 
> -0400
> @@ -26,7 +26,7 @@
>   ## @test test.sh
>   ## @bug 8178870
>   ## @summary test instrumentation.retransformClasses
> -## @run shell test.sh
> +## @run shell test8178870.sh
> 
>   if [ "${TESTSRC}" = "" ]
>   then
> 
> 
> 
> [zgu at localhost jdk8u-dev]$ ~/jtreg/bin/jtreg 
> -jdk:/home/zgu/ws/jdk8u-dev/build/linux-x86_64-normal-server-fastdebug/images/j2sdk-image/ 
> hotspot/test/runtime/RedefineTests/test8178870.sh
> Directory "JTwork" not found: creating
> Directory "JTreport" not found: creating
> Test results: passed: 1
> Report written to /home/zgu/ws/jdk8u-dev/JTreport/html/report.html
> Results written to /home/zgu/ws/jdk8u-dev/JTwork
> 
> 
> -Zhengyu
> 
> 
>> Fixing this will allow the test to run, but it will still fail later 
>> with a
>> ClassNotFoundException.
>>
>> RedefineDoubleDelete will fail during compilation locating 
>> RedefineClassHelper
>> as it does not have @library defined, but after adding it will still 
>> fail with
>> an NPE.
>>
>> -- 
>> David Alvarez
>>
>>
>> On 2019-09-12, 09:47, "jdk8u-dev on behalf of Andrew John Hughes" 
>> <jdk8u-dev-bounces at openjdk.java.net on behalf of 
>> gnu.andrew at redhat.com> wrote:
>>
>>      On 12/09/2019 13:28, Zhengyu Gu wrote:
>>      snip...
>>      >>>>
>>      >>
>>      >> This looks ok. I presume you intend to commit with the correct 
>> metadata,
>>      >> as currently it says "imported patch JDK-8178870_coredump.patch"?
>>      >
>>      > Of course. Otherwise, it won't push.
>>      >
>>      Running jcheck locally [0], I can't even commit something like 
>> that :)
>>      Just wanted to be sure.
>>      [0] https://openjdk.java.net/projects/code-tools/jcheck/
>>      Thanks,
>>      --
>>      Andrew :)
>>      Senior Free Java Software Engineer
>>      Red Hat, Inc. (http://www.redhat.com)
>>      PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
>>      Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
>>      https://keybase.io/gnu_andrew
>>