[8u] 8178870: instrumentation.retransformClasses cause coredump

[Alvarez, David]

> On 2019-09-25, at 07:23, Andrew John Hughes <gnu.andrew at redhat.com> wrote:
> 
> 
> David, can you please confirm Zhengyu's fix makes the test work for you?

By applying the Zhengyu’s patch and my own, all the tests will pass when called
individually or when called as part of a group, like hotspot_tier1.

It seems the test will still fail when jtreg is called to run all the tests in
the test/runtime/RedefineTests, it seems due to the location of the
ClassFileInstaller, although I haven't looked into this yet.

It still means the test is a bit flaky, but at least, call jtreg for a specific
subdir will not be the most common case.

The full patch that I have applied is attached to the bottom of this email.

--
David Alvarez



diff --git a/test/runtime/RedefineTests/RedefineDoubleDelete.java b/test/runtime/RedefineTests/RedefineDoubleDelete.java
index 7b18b45f..1f4533f8 100644
--- a/test/runtime/RedefineTests/RedefineDoubleDelete.java
+++ b/test/runtime/RedefineTests/RedefineDoubleDelete.java
@@ -24,7 +24,11 @@
 /*
  * @test
  * @bug 8178870
+ * @library /testlibrary
  * @summary Redefine class with CFLH twice to test deleting the cached_class_file
+ * @build RedefineClassHelper
+ * @run main RedefineClassHelper
+ * @run main/othervm -javaagent:redefineagent.jar RedefineDoubleDelete
  */

 public class RedefineDoubleDelete {
diff --git a/test/runtime/RedefineTests/test8178870.sh b/test/runtime/RedefineTests/test8178870.sh
index 4a90e265..48d737f0 100644
--- a/test/runtime/RedefineTests/test8178870.sh
+++ b/test/runtime/RedefineTests/test8178870.sh
@@ -26,7 +26,7 @@
 ## @test test.sh
 ## @bug 8178870
 ## @summary test instrumentation.retransformClasses
-## @run shell test.sh
+## @run shell test8178870.sh

 if [ "${TESTSRC}" = "" ]
 then