[8u] RFR 8231463: Fix runtime/RedefineTests/RedefineDoubleDelete.java test in 8u

[Andrew John Hughes]

On 25/09/2019 16:18, Alvarez, David wrote:
> I’m not a reviewer, but I can confirm it fixes the jtreg test.
> 
>> On 25 Sep 2019, at 08:04, Zhengyu Gu <zgu at redhat.com> wrote:
>>
>> During the early  JDK-8178870 8u backport, I converted its test case to shell script, due to imcompatible of test infrastructure.
>>
>> This is no longer the case, we should reverse the test case and eliminate the shell version.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8231463
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8231463/webrev.00/
>>
>> Test:
>>  ~/jtreg/bin/jtreg -v:summary -jdk:${TEST_JDK} hotspot/test/runtime/RedefineTests
>>
>> and
>>
>> ~/jtreg/bin/jtreg -v:summary -jdk:${TEST_JDK} hotspot/test/runtime/RedefineTests/RedefineDoubleDelete.java
>>
>> Thanks,
>>
>> -Zhengyu
>>

I am a reviewer and happy to take into account that this fixes the
issues for David.

The patch looks good to me, and makes the test work for me too:

Before:

$ run_jtreg.sh /usr/lib/jvm/icedtea-8 hotspot/test/runtime/RedefineTests
Java: /usr/lib/jvm/icedtea-8
Test Path: hotspot/test/runtime/RedefineTests
Passed: runtime/RedefineTests/RedefineAnnotations.java
FAILED: runtime/RedefineTests/RedefineDoubleDelete.java
Passed: runtime/RedefineTests/RedefineFinalizer.java
Passed: runtime/RedefineTests/RedefineInterfaceCall.java
Passed: runtime/RedefineTests/RedefineRunningMethods.java
Passed:
runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java
Error:  runtime/RedefineTests/test8178870.sh
Test results: passed: 5; failed: 1; error: 1

After:

$ run_jtreg.sh /usr/lib/jvm/icedtea-8
hotspot/test/runtime/RedefineTestsJava: /usr/lib/jvm/icedtea-8
Test Path: hotspot/test/runtime/RedefineTests
Passed: runtime/RedefineTests/RedefineAnnotations.java
Passed: runtime/RedefineTests/RedefineDoubleDelete.java
Passed: runtime/RedefineTests/RedefineFinalizer.java
Passed: runtime/RedefineTests/RedefineInterfaceCall.java
Passed: runtime/RedefineTests/RedefineRunningMethods.java
Passed:
runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java
Test results: passed: 6

My only worry is that the JDK I tested on is 8u222-b10, and so doesn't
have the 8178870 patch, so are we sure this test is actually verifying
the bug is fixed?

$ /usr/lib/jvm/icedtea-8/bin/java -version
openjdk version "1.8.0_222"
OpenJDK Runtime Environment (IcedTea 3.13.0) (Gentoo icedtea-3.13.0)
OpenJDK 64-Bit Server VM (build 25.222-b10, mixed mode)

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew