[8u] RFR for backport of 8217459 (CRC32 4/4): [PPC64] Cleanup non-vector version of CRC32

Gustavo Romero gromero at linux.vnet.ibm.com
Fri Sep 27 03:32:25 UTC 2019


Hi,

Could the following backport be reviewed please?

Bug     : https://bugs.openjdk.java.net/browse/JDK-8217459
Original: http://hg.openjdk.java.net/jdk/jdk/rev/60add902a57a
Backport: http://cr.openjdk.java.net/~gromero/crc32_jdk8u/for-review/8217459/

It's basically a clean up but can also reduce memory footprint for CRC32
constants. It also puts the CRC32 code in jdk8u in sync with jdk11u code,
helping any future backport. It's a PPC64-only change except for shared code
macros.hpp touched to include two macros not present in jdk8u yet.

It was necessary to backport it to:

- Adapt signature of kernel_crc32_vpmsum(), since parameter 'invertCRC' is not
   necessary and removed on a previous change in this patchset (CRC32 3/4).
- Fix patch not applying clean due to context changes, mostly because
   kernel_crc32_vpmsum() and kernel_crc32_1word() parameter 'is_crc32c' was
   removed on previous changes in this patchset
- Add {BIG,LITTLE}_ENDIAN_ONLY to src/share/vm/utilities/macros.hpp

Thank you.

Best regards,
Gustavo


More information about the jdk8u-dev mailing list