[8u] RFR(XS) 8231494: fix a typo in hash functions
Liu, Xin
xxinliu at amazon.com
Sat Sep 28 05:27:13 UTC 2019
Hi, Andrew,
I just notice that you have sent a backport review to jdk8u.
In this morning, I replied you but I sent to 'jdk8u-dev <jdk8u-dev-bounces at openjdk.java.net>', it probably went to nowhere.
I read you CR. It's almost same as mine, but yours has better comments, So please go ahead. I've closed JDK-8231494.
Thanks,
--lx
On 9/27/19, 10:11 PM, "jdk8u-dev on behalf of Liu, Xin" <jdk8u-dev-bounces at openjdk.java.net on behalf of xxinliu at amazon.com> wrote:
Hi, Andrew,
Here is the webrev for the backported patch.
https://cr.openjdk.java.net/~xliu/8055283/webrev/
I only modified one line.
+ bool put(K const& key, V const& value) {
Forget about JDK-8231494, I will close it after the backport goes into jdk8u-dev.
Thanks,
--lx
On 9/27/19, 1:41 PM, "jdk8u-dev on behalf of Liu, Xin" <jdk8u-dev-bounces at openjdk.java.net on behalf of xxinliu at amazon.com> wrote:
Hi, Andrew,
I backported it and verified the test using hotspot/test/sanity/ExecuteInternalVMTests.java
Here is webrev.
https://cr.openjdk.java.net/~xliu/8231494/v1/webrev/
jdk8u-dev can apply the patch almost clean.
The only thing I changed is make ResourceHashtable::put return a Boolean value.
+ bool put(K const& key, V const& value) {
The test needs it.
I also add label 'jdk8u-fix-request' to JDK-8055283
Thanks,
--lx
On 9/26/19, 10:32 AM, "jdk8u-dev on behalf of Liu, Xin" <jdk8u-dev-bounces at openjdk.java.net on behalf of xxinliu at amazon.com> wrote:
Hi, reviewer,
Could you review this trivial change? I think it’s a typo and get better hash function.
JBS: https://bugs.openjdk.java.net/browse/JDK-8231494
Webrev: https://cr.openjdk.java.net/~xliu/8231494/webrev/
I didn’t backport JDK-8055283 because it’s not necessary.
Thanks,
--lx
More information about the jdk8u-dev
mailing list