RFR 8241285(s): [jdk8u] fail to build hotspot with gcc-8.4.0 with or without COMPILER_WARNINGS_FATAL(Internet mail)

[Hohensee, Paul]

I believe you need only one review for a backport, so you can now tag the issue with jdk8-fix-request and a 'Fix Request (8u)' comment.

Thanks,
Paul

On 3/31/20, 9:58 PM, "linzang(臧琳)" <linzang at tencent.com> wrote:

    Dear All,
    
    May I ask your help to review this small change? And may I ask help of pushing it if a go decision is made.
    Thanks.
    
    BRs,
    Lin
    
    On 2020/3/30, 10:41 AM, "linzang(臧琳)" <linzang at tencent.com> wrote:
    
        Thanks Paul!
        Dear All,  may I get more review about this patch?  Or may I get help for tesitng it on platfrom other than bsd and Linux?
    
        Thanks!
    
    
    
        BRs,
        Lin
    
        On 2020/3/25, 9:29 PM, "Hohensee, Paul" <hohensee at amazon.com> wrote:
    
            It would be great if someone could build on the other platforms. Otherwise, lgtm.
    
            Paul
    
            On 3/24/20, 11:22 PM, "linzang(臧琳)" <linzang at tencent.com> wrote:
    
                CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
    
    
    
                Hi Paul,
                     Thanks for your comments, I hava upload  a new patch http://cr.openjdk.java.net/~lzang/8241285/webrev03
    
                   >>     Has it been tested on all affected platforms?
                     No, I only test on macos and linux, since they are the only platforms I could find.
    
                BRs,
                Lin
    
                On 2020/3/25, 12:19 AM, "Hohensee, Paul" <hohensee at amazon.com> wrote:
    
                    In make/solaris/makefiles/gcc.make, the WARNINGS_ARE_ERRORS line should be indented 2 spaces.
    
                    For aix, the COMPILER_WARNINGS_FATAL check looks like it should go in xlc.make. Code would be the same as in make/linux/makefiles/gcc.make.
    
                    Has it been tested on all affected platforms?
    
                    Paul
    
                    On 3/24/20, 7:12 AM, "linzang(臧琳)" <linzang at tencent.com> wrote:
    
                        Dear Paul and Andrew，
                             May I ask your help to review this new patch?and help to push it if it is ok.
    
                        Thanks!
    
                        BRs,
                        Lin
    
                        > 在 2020年3月21日，上午1:00，linzang(臧琳) <linzang at tencent.com> 写道：
                        >
                        > Dear Paul and Andrew,
                        >
                        >    A new patch has been uploaded to http://cr.openjdk.java.net/~lzang/8241285/webrev02
                        >    Would you like to help review it? Thanks.
                        >
                        >
                        >
                        > BRs,
                        > Lin
                        >
                        > > On 2020/3/20, 11:47 PM, "Hohensee, Paul" <hohensee at amazon.com> wrote:
                        >>
                        >>    Lgtm. I see that Andrew has approved 8241285 as an 8u-only patch (extended to all unixen).
                        >>
                        >>    Paul
                        >>
                        >>    On 3/19/20, 8:31 PM, "linzang(臧琳)" <linzang at tencent.com> wrote:
                        >>
                        >>        Dear Paul,
                        >>            Thanks for your suggestion, it seems https://bugs.openjdk.java.net/browse/JDK-8144695 was introduced to fix this issue on jdk9, by changing "WARNINGS_AS_ERROR=" to " WARNINGS_AS_ERROR?=".
                        >>            But it is based on "--disable-warnings-as-errors" flag, and this flag set a global WARNINGS_AS_ERROR flag, which jdk8 doesn't have it, so simply backport the patch can't solve the problem.
                        >>            I have made some change based on it . and I will mark my fix as backport.
                        >>            And I have updated the patch based on the fix of https://bugs.openjdk.java.net/browse/JDK-8144695.
                        >>            Webrev: http://cr.openjdk.java.net/~lzang/8241285/webrev01/
                        >>            Would you like to help review?  Thanks.
                        >>
                        >>
                        >>        BRs,
                        >>        Lin
                        >>
                        >>>> On 2020/3/20, 2:11 AM, "Hohensee, Paul" <hohensee at amazon.com> wrote:
                        >>>
                        >>>    Is there an existing JBS issue you can backport to get the same effect?
                        >>>
                        >>>    Thanks,
                        >>>    Paul
                        >>>
                        >>>>    On 3/19/20, 7:00 AM, "jdk8u-dev on behalf of linzang(臧琳)" <jdk8u-dev-bounces at openjdk.java.net on behalf of linzang at tencent.com> wrote:
                        >>>
                        >>>        Dear All,
                        >>>             Would you like to help review this tiny fix of build hotspot with gcc-8.4.0?
                        >>>             Bug: https://bugs.openjdk.java.net/browse/JDK-8241285
                        >>>             Webrev: http://cr.openjdk.java.net/~lzang/8241285/webrev/
                        >>>
                        >>>            The fix makes gcc consider COMPILER_WARNINGS_FATAL flag, when it set to false, the warnings from gcc will not be treated as error.
                        >>>
                        >>>        BRs,
                        >>>        Lin
                        >
                        >
                        >
                        >
                        >
                        >
                        >
                        >
                        >