[8u] RFR: 4949105: Access Bridge lacks html tags parsing

[Andrew Hughes]

On 27/03/2020 20:54, Alex Kashchenko wrote:
> Hi,
> 
> Please review the backport of JDK-4949105 to 8u:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-4949105
> 
> Original review thread:
> http://mail.openjdk.java.net/pipermail/swing-dev/2019-September/009793.html
> 
> 11u changeset:
> https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/628d3e224aaa
> 
> 8u webrev: http://cr.openjdk.java.net/~akasko/jdk8u/4949105/webrev.00/
> 
> 8u specific changes: paths, copyright year, String.strip() replaced with
> trim().
> 
> On the strip() change: while trim() and strip() are not equivalent
> (details: https://bugs.openjdk.java.net/browse/JDK-8200378 ), trim() may
> be appropriate here for 8u.
> 

Well, what you don't mention is that strip() is not an option for 8u, as
it doesn't exist :)

One could implement an appropriate isWhitespace()-based trimming routine
instead, but I suspect there are enough uses of trim() already in the 8u
codebase to make this out of scope for this backport and too risky for a
stable codebase.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222