RFR 8241285(s): [jdk8u] fail to build hotspot with gcc-8.4.0 with or without COMPILER_WARNINGS_FATAL(Internet mail)

[linzang(臧琳)]

Hi Andrew， 
     Do you think http://cr.openjdk.java.net/~lzang/8241285/webrev04/ is ready for push? 
     P.S. it is hard for me to find AIX environment to test, if it is a problem, may I ask your help? 
     Thanks!

BRs,
Lin

On 2020/4/2, 4:49 PM, "linzang(臧琳)" <linzang at tencent.com> wrote:

    Dear Andrew, 
          Thanks for your comments, I have uploaded a new patch at http://cr.openjdk.java.net/~lzang/8241285/webrev04/. 
          Would you like to help review it again? 
    BRs,
    Lin
    
    On 2020/4/2, 2:10 AM, "Andrew Hughes" <gnu.andrew at redhat.com> wrote:
    
        
        
        On 25/03/2020 06:21, linzang(臧琳) wrote:
        > Hi Paul, 
        >      Thanks for your comments, I hava upload  a new patch http://cr.openjdk.java.net/~lzang/8241285/webrev03
        >     
        >    >>     Has it been tested on all affected platforms?
        >      No, I only test on macos and linux, since they are the only platforms I could find. 
        >  
        > BRs,
        > Lin
        > 
        
        A few comments:
        
        * make/aix/makefiles/xlc.make
          - This doesn't seem to do anything as WARNINGS_ARE_ERRORS is never
        used. I suspect EXTRA_WARNINGS should be replaced by
        WARNINGS_ARE_ERRORS, but it would be good to have some feedback from AIX
        people.
          - There seems to be a blank line being added for no reason.
        
        * make/solaris/makefiles/adlc.make
          - Bogus whitespace change to "We need libCstd.so for adlc" line
          - -errwarn gets replaced by -xwe. I think it would be better to revert
        this unless there is a good reason to change it.
        * make/solaris/makefiles/sparcWorks.make
          - Missing indenting.
        
        Should be ok with those issues fixed.
        
        Thanks,
        -- 
        Andrew :)
        
        Senior Free Java Software Engineer
        Red Hat, Inc. (http://www.redhat.com)
        
        PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
        Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222