RFR: [8u] JDK-8191393: Random crashes during cfree+0x1c

[Andrew Dinn]

On 06/04/2020 11:43, Liu, Xin wrote:
> Hi,  Reviewers, 
> 
> May I request review this bugfix? 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8191393
> Webrev: https://cr.openjdk.java.net/~xliu/8191393/webrev/
> 
> I believe that root cause  is the race condition between ConcurrentMarkThread and the VMThread.
> We can’t directly backport from upstream because upstream is based on unified logging framework. further, TIP doesn’t have reentry problem while jdk8u has. 
> Instead, this patch uses a mutex to protect FILE* fileStream::_file and a Boolean flag to avoid reentry.  
> 
> Of course, a mutex  is not free. Therefore, I didn't use it if users don't emit log to file. 
> 
> Test: 
> I ran the stress test over 24 hours and no problem is identified. 
> I passed tier1 test of jtreg. 
That looks good to me.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill