RFR(s): 8241638: [backport] launcher time metrics always report 1 on Linux when _JAVA_LAUNCHER_DEBUG set(Internet mail)

[Hohensee, Paul]

Thanks for noticing the copyright issue, Xin. Lgtm too.

Paul

On 4/24/20, 1:36 AM, "Liu, Xin" <xxinliu at amazon.com> wrote:

    LGTM. Thanks.


    On 4/23/20, 7:33 PM, "linzang(臧琳)" <linzang at tencent.com> wrote:

        Hi Paul and Xin,
             Thanks for your guidance, I have uploaded a webrev02 that fixing the copyrights issue Xin pointed out.
             And updated the comments at https://bugs.openjdk.java.net/browse/JDK-8241638.

        BRs,
        Lin

        On 2020/4/24, 7:32 AM, "Liu, Xin" <xxinliu at amazon.com> wrote:

            Oh, no! sorry I sent misinformation here.
            I am *NOT* a reviewer. I just offer helps to eyeball trivial issues.
            --lx

            On 4/23/20, 4:23 PM, "jdk8u-dev on behalf of Liu, Xin" <jdk8u-dev-bounces at openjdk.java.net on behalf of xxinliu at amazon.com> wrote:

                Hi, Zang,

                I am now a reviewer. I just offer helps to eyeball trivial issues.

                The patch is almost a clean backport. As long as you declare the  patch can apply to jdk8u cleanly,  I think you can skip the formal review.
                1. the only difference from original patch is java_md_macosx.m->java_md_macosx.c. I think it's the same file in different names.
                2. I think you should place a whitespace in the copyrights section of java_md_solinux.h.
                "* Copyright (c) 2013,[ ]2020 Oracle and/or its affiliates. All rights reserved."

                Thanks,
                --lx

                On 4/22/20, 10:56 PM, "jdk8u-dev on behalf of linzang(臧琳)" <jdk8u-dev-bounces at openjdk.java.net on behalf of linzang at tencent.com> wrote:

                    CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



                    Dear All,
                         May I ask your help to review the tiny patch about backport of 8241638?
                         Issue: https://bugs.openjdk.java.net/browse/JDK-8241638
                         Patch: http://cr.openjdk.java.net/~lzang/8241638/8u/webrev01/

                    BRs,
                    Lin